Allow running non-deterministic MDX stanzas using dune-gen
#366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
emillon
reviewed
Jan 27, 2022
Thanks to @emillon for pointing out all the shortcut that dune allows to avoid declaring things over and over.
This should be more portable since we don't depend on `diff` being installed or have an exit code of 1 when the files differ.
emillon
added a commit
to ocaml/dune
that referenced
this pull request
Jan 27, 2022
Since realworldocaml/mdx#366, the executable output by `ocaml-mdx dune-gen` supports `MDX_RUN_NON_DETERMINISTIC` like `ocaml-mdx test` itself. Dune needs to know about that to rerun the tests if the variable has been set in the meantime. Signed-off-by: Etienne Millon <[email protected]>
emillon
added a commit
to ocaml/dune
that referenced
this pull request
Jan 27, 2022
Since realworldocaml/mdx#366, the executable output by `ocaml-mdx dune-gen` supports `MDX_RUN_NON_DETERMINISTIC` like `ocaml-mdx test` itself. Dune needs to know about that to rerun the tests if the variable has been set in the meantime. Signed-off-by: Etienne Millon <[email protected]>
NathanReb
approved these changes
Jan 28, 2022
|
That's a good point for the future. Unfortunately that would require us to use a dune version that has either 0.1 support or 0.2 support (the latter is dune 3.0 which is not released yet) unless we want to do a fun thing and declare: |
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Jan 28, 2022
CHANGES: #### Added - Add support for adding language tags and metadata labels in `mli` files. (realworldocaml/mdx#339, realworldocaml/mdx#357, @Julow, @Leonidas-from-XIV) - Add support for running non-deterministic tests in `dune` MDX 0.2 stanza by setting the `MDX_RUN_NON_DETERMINISTIC` environment variable. (realworldocaml/mdx#365, realworldocaml/mdx#366, @Leonidas-from-XIV)
That's done in ocaml/dune#5391. This only affects stanza 0.2 which is unreleased at the moment. |
|
That's a good point indeed. On the other hand I think that it wouldn't be too bad for MDX to require the version of dune that integrates well with it. We don't really offer good support for running MDX on your own anyway. We'd need to look into the implications more carefully but on principle, I think it could work. |
|
We can also test this by doing what the stanza does by hand, ie something like that in a cram test: It's an e2e test of dune-gen, not of the dune stanza, but this ensures that this contract works. |
emillon
added a commit
to ocaml/dune
that referenced
this pull request
Jan 31, 2022
Since realworldocaml/mdx#366, the executable output by `ocaml-mdx dune-gen` supports `MDX_RUN_NON_DETERMINISTIC` like `ocaml-mdx test` itself. Dune needs to know about that to rerun the tests if the variable has been set in the meantime. Signed-off-by: Etienne Millon <[email protected]>
emillon
added a commit
to ocaml/dune
that referenced
this pull request
Feb 7, 2022
Since realworldocaml/mdx#366, the executable output by `ocaml-mdx dune-gen` supports `MDX_RUN_NON_DETERMINISTIC` like `ocaml-mdx test` itself. Dune needs to know about that to rerun the tests if the variable has been set in the meantime. Signed-off-by: Etienne Millon <[email protected]>
emillon
added a commit
to ocaml/dune
that referenced
this pull request
Feb 7, 2022
Since realworldocaml/mdx#366, the executable output by `ocaml-mdx dune-gen` supports `MDX_RUN_NON_DETERMINISTIC` like `ocaml-mdx test` itself. Dune needs to know about that to rerun the tests if the variable has been set in the meantime. Signed-off-by: Etienne Millon <[email protected]>
emillon
added a commit
to ocaml/dune
that referenced
this pull request
Feb 8, 2022
Since realworldocaml/mdx#366, the executable output by `ocaml-mdx dune-gen` supports `MDX_RUN_NON_DETERMINISTIC` like `ocaml-mdx test` itself. Dune needs to know about that to rerun the tests if the variable has been set in the meantime. Signed-off-by: Etienne Millon <[email protected]>
rgrinberg
pushed a commit
to ocaml/dune
that referenced
this pull request
Feb 10, 2022
Since realworldocaml/mdx#366, the executable output by `ocaml-mdx dune-gen` supports `MDX_RUN_NON_DETERMINISTIC` like `ocaml-mdx test` itself. Dune needs to know about that to rerun the tests if the variable has been set in the meantime. Signed-off-by: Etienne Millon <[email protected]>
rgrinberg
pushed a commit
to ocaml/dune
that referenced
this pull request
Feb 10, 2022
Since realworldocaml/mdx#366, the executable output by `ocaml-mdx dune-gen` supports `MDX_RUN_NON_DETERMINISTIC` like `ocaml-mdx test` itself. Dune needs to know about that to rerun the tests if the variable has been set in the meantime. Signed-off-by: Etienne Millon <[email protected]>
rgrinberg
pushed a commit
to ocaml/dune
that referenced
this pull request
Feb 10, 2022
Since realworldocaml/mdx#366, the executable output by `ocaml-mdx dune-gen` supports `MDX_RUN_NON_DETERMINISTIC` like `ocaml-mdx test` itself. Dune needs to know about that to rerun the tests if the variable has been set in the meantime. Signed-off-by: Etienne Millon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a number of ways this could be implemented, but for simplicity this just uses the same environment variable as the main executable, but to avoid dependencies it doesn't use the Cmdliner flag.
Closes #365.